Move node_tilable_track_nums_ to rr_graph_storage and add remove_node #3347

amin1377 · 2025-11-17T23:24:07Z

This PR depends on PR #3342. Please wait until that PR is merged.

In this PR, node_tilable_track_nums_ is moved into the RR graph storage instead of residing in the RR graph builder, since this data structure (when using a tileable RR graph) needs to remain valid for the entire lifetime of the RR graph.

Additionally, a method is added to facilitate removing nodes from the RR graph.

…to-routing/vtr-verilog-to-routing into remove_node

…ile if graph type is tileable

…to-routing/vtr-verilog-to-routing into remove_node

AmirhosseinPoolad · 2025-11-18T00:19:05Z

What's the use case of removing nodes?

amin1377 · 2025-11-18T12:30:16Z

What's the use case of removing nodes?

For the custom RR graph, in the other PR there are channel nodes, particularly around the perimeter of the device, that don’t have any fan-in. We need to remove these nodes after the graph is created. I considered not adding them in the first place, but that’s difficult to determine before the edges are added.

As we discussed earlier, I’m trying to break the custom RR graph PR into multiple smaller PRs to make the review process easier.

…rilog-to-routing into remove_node

…to-routing/vtr-verilog-to-routing into remove_node

…rilog-to-routing into remove_node

AmirhosseinPoolad

Thanks for the PR Amin. Had some comments.

libs/librrgraph/src/base/rr_graph_builder.cpp

libs/librrgraph/src/base/rr_graph_storage.cpp

libs/librrgraph/src/base/rr_graph_storage.h

libs/librrgraph/src/io/rr_graph_reader.cpp

libs/librrgraph/src/base/rr_graph_storage.cpp

libs/librrgraph/src/base/rr_graph_storage.h

libs/librrgraph/src/base/rr_graph_storage.cpp

AmirhosseinPoolad

Misclicked, didn't mean to approve. Sorry!

…rilog-to-routing into remove_node

…parse_ptc_numbers to rr graph util

amin1377 · 2025-11-24T16:36:26Z

Misclicked, didn't mean to approve. Sorry!

I’ll happily take that approval anyway 😁

amin1377 · 2025-11-24T16:37:17Z

@AmirhosseinPoolad: I’ve addressed your comments. I’d appreciate it if you could take another look at the PR and let me know if you have any further feedback. It would be great if we could finalize this PR today!

AmirhosseinPoolad

Sorry for being late! This looks good other than the lambda capture list (super dangerous imo to capture everything by non-const reference and it wouldn't be clear to future maintainers which outside variables the lambda is actually using without going through the lambda code). I still need another person to look at the flag change.

…rilog-to-routing into remove_node

amin1377 · 2025-11-28T16:38:33Z

Thanks, @AmirhosseinPoolad . I’ve applied the changes you recommended. Please let me know if you have any further comments.

AmirhosseinPoolad

Looks good!

…rilog-to-routing into remove_node

amin1377 added 13 commits November 17, 2025 11:08

[lib][rr_graph] initial impl for remove node

615bd5a

[libs][rr_graph] uniquify remove edges

511f89d

Merge branch 'rr_graph_interposer_cut' of https://github.com/verilog-…

112a6c0

…to-routing/vtr-verilog-to-routing into remove_node

[lib][rr_graph] add comments + shrink rr graph node data structures

5bbf3d7

fix a typo

dfc2a33

[lib][rr_graph] remove node_tilable_track_nums_ from rr graph builder

ec0a8e5

[lib][rr_graph] add node_tilable_track_nums_ to rr graph storage

7817922

[lib][rr_grpah] remove node_tileable_track_nums_ from rr_graph_view

54ff743

[lib][librrgraph] set tileable to true when reading rr graph from a f…

3da38b0

…ile if graph type is tileable

[libs][rrgraph] remove redundant function call

dda1dd5

[vpr] fix instances of rr graph view

de52b91

[lib][rr_graph] add remove_node header

4830963

[lib][rr_graph] erase node_tilable_track_nums_ when removing a node

3b9f552

github-actions bot added VPR VPR FPGA Placement & Routing Tool docs Documentation lang-cpp C/C++ code labels Nov 17, 2025

Merge branch 'rr_graph_interposer_cut' of https://github.com/verilog-…

5f49e17

…to-routing/vtr-verilog-to-routing into remove_node

amin1377 added 3 commits November 20, 2025 09:12

Merge branch 'master' of https://github.com/verilog-to-routing/vtr-ve…

99e40a2

…rilog-to-routing into remove_node

Merge branch 'rr_graph_interposer_cut' of https://github.com/verilog-…

ec9b088

…to-routing/vtr-verilog-to-routing into remove_node

[lib][rr_graph][storage] fix bugs with remove_nodes

e5a0f13

amin1377 requested a review from AmirhosseinPoolad November 20, 2025 17:34

amin1377 changed the title ~~[WIP] Move node_tilable_track_nums_ to rr_graph_storage and add remove_node~~ Move node_tilable_track_nums_ to rr_graph_storage and add remove_node Nov 20, 2025

github-actions bot added the libarchfpga Library for handling FPGA Architecture descriptions label Nov 20, 2025

Merge branch 'master' of https://github.com/verilog-to-routing/vtr-ve…

513115d

…rilog-to-routing into remove_node

AmirhosseinPoolad approved these changes Nov 20, 2025

View reviewed changes

AmirhosseinPoolad requested changes Nov 20, 2025

View reviewed changes

amin1377 added 2 commits November 21, 2025 09:41

Merge branch 'master' of https://github.com/verilog-to-routing/vtr-ve…

10a876a

…rilog-to-routing into remove_node

Merge branch 'master' of https://github.com/verilog-to-routing/vtr-ve…

52637f2

…rilog-to-routing into remove_node

amin1377 added 7 commits November 21, 2025 12:56

[ci] update flat router results based on extracted results from ci

684c864

Merge branch 'master' of https://github.com/verilog-to-routing/vtr-ve…

4a05ac1

…rilog-to-routing into remove_node

[lib][rr_graph] apply comments for rr_graph_storage

cf49863

[lib][rr_graph] pass vector of ptc nums to set_node_ptc_nums and add …

7129eda

…parse_ptc_numbers to rr graph util

[lib][rr_graph] fix node_offset check in add_node_tilable_track_num

955502d

[lib][rr_graph] add node_ptc_number_to_string

3c7b677

[lib][rr_graph] remove ptc_to_string from rr_graph_builder

79694d3

amin1377 added 5 commits November 24, 2025 08:37

[lib][rr_graph] add comments

6dfc2c3

[lib][rr_graph] fix iterator idx

838d5f9

fix a typo

20fde60

[ci] update flat router golden result

d5a5555

[lib][rr_graph] remove unlock_storage

167a46c

AmirhosseinPoolad reviewed Nov 27, 2025

View reviewed changes

amin1377 added 2 commits November 28, 2025 08:06

Merge branch 'master' of https://github.com/verilog-to-routing/vtr-ve…

5c2a525

…rilog-to-routing into remove_node

[lib][rr_graph] pass required variables to lambda function

851a2cd

AmirhosseinPoolad approved these changes Nov 28, 2025

View reviewed changes

Merge branch 'master' of https://github.com/verilog-to-routing/vtr-ve…

6555071

…rilog-to-routing into remove_node

amin1377 merged commit 08f357f into master Nov 28, 2025
30 checks passed

amin1377 deleted the remove_node branch November 28, 2025 21:22

Move node_tilable_track_nums_ to rr_graph_storage and add remove_node #3347

Move node_tilable_track_nums_ to rr_graph_storage and add remove_node #3347

Conversation

amin1377 commented Nov 17, 2025

Uh oh!

AmirhosseinPoolad commented Nov 18, 2025

Uh oh!

amin1377 commented Nov 18, 2025

Uh oh!

AmirhosseinPoolad left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AmirhosseinPoolad left a comment

Choose a reason for hiding this comment

Uh oh!

amin1377 commented Nov 24, 2025

Uh oh!

amin1377 commented Nov 24, 2025

Uh oh!

AmirhosseinPoolad left a comment

Choose a reason for hiding this comment

Uh oh!

amin1377 commented Nov 28, 2025

Uh oh!

AmirhosseinPoolad left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants